Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checker): add libmemcached checker #2862

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat(checker): add libmemcached checker #2862

merged 1 commit into from
Mar 29, 2023

Conversation

ffontaine
Copy link
Contributor

No description provided.

@ffontaine
feat(checker): add libmemcached checker
aa0d701 
Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023 •
edited
Loading

Codecov Report

Merging #2862 (aa0d701) into main (7c9a67d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   82.94%   83.04%   +0.10%     
==========================================
  Files         653      655       +2     
  Lines       10411    10421      +10     
  Branches     1409     1409              
==========================================
+ Hits         8635     8654      +19     
+ Misses       1417     1411       -6     
+ Partials      359      356       -3
Flag Coverage Δ
longtests 82.56% <100.00%> (+0.12%) ⬆️
win-longtests 80.56% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.34% <ø> (ø)
cve_bin_tool/checkers/libmemcached.py 100.00% <100.00%> (ø)
test/test_data/libmemcached.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

terriko
terriko approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we may have reached the point where we have too many checkers for the tests to be consistently done in 20 minutes, so I'm going to try bumping the timeouts.

@terriko terriko merged commit e0e6a98 into intel:main Mar 29, 2023
@ffontaine ffontaine deleted the add-libmemcached-checker branch March 29, 2023 16:15
terriko pushed a commit to anthonyharrison/cve-bin-tool that referenced this pull request Mar 30, 2023
@ffontaine @terriko
feat(checker): add libmemcached checker (intel#2862)
f805bca 
Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffontaine @codecov-commenter @terriko